Skip to content

feat: add back source attribute for backward compatibility #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: add back source attribute for backward compatibility #407

merged 2 commits into from
Jan 22, 2025

Conversation

@badGarnet
Copy link
Collaborator

@badGarnet badGarnet commented Jan 22, 2025

This PR adds source back to TextRegions and LayoutElements for backward compatibility.

@badGarnet badGarnet marked this pull request as ready for review January 22, 2025 17:53
@badGarnet badGarnet requested a review from tbs17 January 22, 2025 17:53
tbs17
tbs17 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@tbs17 tbs17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@badGarnet badGarnet merged commit 85bcdc1 into main Jan 22, 2025
14 checks passed
@badGarnet badGarnet deleted the feat/back-compat-for-sources branch January 22, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tbs17 tbs17 tbs17 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badGarnet @tbs17